Fix run_generation test commands for TRL out usage example#1621
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
libinta
approved these changes
Dec 17, 2024
skaulintel
approved these changes
Dec 17, 2024
huijuanzh
pushed a commit
to huijuanzh/optimum-habana
that referenced
this pull request
Jan 7, 2025
…ce#1621) Fix run_generation example for TRL out
Liangyx2
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jan 20, 2025
…ce#1621) Fix run_generation example for TRL out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DPO pipeline section, it shows run_generation.py command which it runs with DPO output.
The DPO output (./dpo) is generated from llama2-70b-hf, but the examples (merging/run_generation) are basing llama2-7b-hf.
It fails with wrong dimension during merging and OOM when it runs run_generation test.