Add the inline_inbuilt_nn_modules option #1617
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to performance degradation in certain models（e.g. ALBERT_XXL）. A configuration option has been introduced to turn off this behavior
chaojun-zhang
force-pushed
the
auto-pr-c596104
branch
from
e62c993 to
4c1b7f8
Compare
ssarkar2
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Adding notes for my understanding
without this change:
torch._dynamo.config.inline_inbuilt_nn_modules = True
https://github.com/pytorch/pytorch/blob/main/torch/_dynamo/config.py#L412C33-L412C42
with this change we give an option to set it to True or False. We set it to false in case of albert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling the inline_inbuilt_nn_modules switch will restore ALBERT-XXL's performance to PyTorch 2.4 levels
What does this PR do?
Fixes # (issue)
Before submitting