Skip to content

Fix fast CI to work with split runners #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
regisss merged 17 commits into from
Nov 28, 2024
Merged

Fix fast CI to work with split runners #1534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b46f202
Set number of devices to 2 for fast distributed tests
regisss Nov 27, 2024
3bca329
Debug
regisss Nov 27, 2024
d07b06c
Debug
regisss Nov 27, 2024
3109c27
Debug
regisss Nov 27, 2024
3521d69
Debug
regisss Nov 27, 2024
cb3585e
Debug
regisss Nov 27, 2024
01d8a81
Debug
regisss Nov 27, 2024
c35141b
Debug
regisss Nov 27, 2024
88107af
Debug
regisss Nov 27, 2024
4c0fb7b
Debug
regisss Nov 27, 2024
3e61733
Debug
regisss Nov 27, 2024
b5fd947
Debug
regisss Nov 28, 2024
f92c558
Debug
regisss Nov 28, 2024
e42299b
Debug
regisss Nov 28, 2024
9577b3a
Remove debug
regisss Nov 28, 2024
ef84161
Remove debug
regisss Nov 28, 2024
550b0df
Add hl-smi to fast_test_diffusers.sh
regisss Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/fast_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ jobs:
name: Run tests for optimum.habana.transformers
runs-on: [self-hosted, linux, x64, gaudi2, fast]
steps:
- name: Test HABANA_VISIBLE_DEVICES
run: |
echo $HABANA_VISIBLE_DEVICES
- name: Checkout
uses: actions/checkout@v2
- name: Pull image
Expand All @@ -33,7 +30,7 @@ jobs:
-v /scratch-1:/data \
--workdir=/root/workspace \
--runtime=habana \
-e HABANA_VISIBLE_DEVICES=$HABANA_VISIBLE_DEVICES \
-e HABANA_VISIBLE_DEVICES=$DOCKER_HABANA_VISIBLE_DEVICES \
-e OMPI_MCA_btl_vader_single_copy_mechanism=none \
-e HF_HOME=/data \
--cap-add=sys_nice \
Expand All @@ -45,9 +42,6 @@ jobs:
name: Run tests for optimum.habana.diffusers
runs-on: [self-hosted, linux, x64, gaudi2, fast]
steps:
- name: Test HABANA_VISIBLE_DEVICES
run: |
echo $HABANA_VISIBLE_DEVICES
- name: Checkout
uses: actions/checkout@v2
- name: Pull image
Expand All @@ -61,7 +55,7 @@ jobs:
-v /scratch-1:/data \
--workdir=/root/workspace \
--runtime=habana \
-e HABANA_VISIBLE_DEVICES=$HABANA_VISIBLE_DEVICES \
-e HABANA_VISIBLE_DEVICES=$DOCKER_HABANA_VISIBLE_DEVICES \
-e OMPI_MCA_btl_vader_single_copy_mechanism=none \
-e HF_HOME=/data \
--cap-add=sys_nice \
Expand Down
2 changes: 2 additions & 0 deletions tests/ci/fast_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#!/bin/bash

echo "Visible devices: $HABANA_VISIBLE_DEVICES"
hl-smi
python -m pip install --upgrade pip
make fast_tests
2 changes: 2 additions & 0 deletions tests/ci/fast_tests_diffusers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#!/bin/bash

echo "Visible devices: $HABANA_VISIBLE_DEVICES"
hl-smi
python -m pip install --upgrade pip
make fast_tests_diffusers
2 changes: 1 addition & 1 deletion tests/test_trainer_distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def _test_gaudi_trainer_distributed(self, kwargs={}):

distributed_runner = DistributedRunner(
command_list=command,
world_size=8,
world_size=2,
use_mpi=True,
)

Expand Down