Skip to content

Fix Llama 3.1 generation #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
regisss merged 2 commits into from
Oct 20, 2024
Merged

Fix Llama 3.1 generation #1444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f1393b
Properly set pad_token_id
regisss Oct 20, 2024
11add9e
LoRA example
regisss Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions examples/language-modeling/run_lora_clm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,10 +700,6 @@ def main():
raise ValueError("Must provide model_name_or_path to load a pretrained CausalLM model.")

if model.config.model_type == "llama":
# unwind broken decapoda-research config
model.generation_config.pad_token_id = 0
model.generation_config.bos_token_id = 1
model.generation_config.eos_token_id = 2
if model_args.attn_softmax_bf16:
model.generation_config.attn_softmax_bf16 = True
if model_args.use_flash_attention:
Expand Down
22 changes: 14 additions & 8 deletions examples/text-generation/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,16 +525,22 @@ def setup_tokenizer(args, model, assistant_model):
tokenizer.padding_side = "left"

if model.config.model_type == "llama":
# unwind broken decapoda-research config
model.generation_config.pad_token_id = 0
model.generation_config.bos_token_id = 1
model.generation_config.eos_token_id = 2
if model.generation_config.pad_token_id is None:
if isinstance(model.generation_config.eos_token_id, int):
model.generation_config.pad_token_id = model.generation_config.eos_token_id
elif isinstance(model.generation_config.eos_token_id, list):
model.generation_config.pad_token_id = model.generation_config.eos_token_id[0]
if assistant_model is not None:
assistant_model.generation_config.pad_token_id = 0
assistant_model.generation_config.bos_token_id = 1
assistant_model.generation_config.eos_token_id = 2
if assistant_model.generation_config.pad_token_id is None:
if isinstance(assistant_model.generation_config.eos_token_id, int):
assistant_model.generation_config.pad_token_id = assistant_model.generation_config.eos_token_id
elif isinstance(assistant_model.generation_config.eos_token_id, list):
assistant_model.generation_config.pad_token_id = assistant_model.generation_config.eos_token_id[0]
tokenizer.bos_token_id = model.generation_config.bos_token_id
tokenizer.eos_token_id = model.generation_config.eos_token_id
if isinstance(model.generation_config.eos_token_id, int):
tokenizer.eos_token_id = model.generation_config.eos_token_id
elif isinstance(model.generation_config.eos_token_id, list):
tokenizer.eos_token_id = model.generation_config.eos_token_id[0]
tokenizer.pad_token_id = model.generation_config.pad_token_id
tokenizer.pad_token = tokenizer.decode(tokenizer.pad_token_id)
tokenizer.eos_token = tokenizer.decode(tokenizer.eos_token_id)
Expand Down