Skip to content

Added missing condition check when using --run_partial_dataset#1416

Closed
yeonsily wants to merge 1 commit into
mainfrom
textgen_fix
Closed

Added missing condition check when using --run_partial_dataset#1416
yeonsily wants to merge 1 commit into
mainfrom
textgen_fix

Conversation

@yeonsily
Copy link
Copy Markdown
Collaborator

@yeonsily yeonsily commented Oct 15, 2024

What does this PR do?

@regisss --run_partial_dataset parameter is added by #1364 to ci_11102024 tag not main yet.
But when #1364 is ported, one condition check code is missing compare to optimum-habana-fork change.
We found that issue during our internal CI which using "--n_iterations 500 --dataset_name tatsu-lab/alpaca --run_partial_dataset" in command line. It didn't finish after 500 iterations but kept running through whole dataloader size.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@yeonsily yeonsily requested a review from libinta October 15, 2024 00:15
@yeonsily yeonsily requested a review from regisss as a code owner October 15, 2024 00:15
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yafshar
Copy link
Copy Markdown
Contributor

yafshar commented Oct 15, 2024

@yeonsily, there is another duplicate PR at #1420

@yeonsily
Copy link
Copy Markdown
Collaborator Author

@regisss I close this PR as #1420 is propagated by the original author.

@yeonsily yeonsily closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants