Skip to content

Fixed recursion error when uses both wrapped PEFT and DeepSpped #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kplau1128 wants to merge 1 commit into from
Closed

Fixed recursion error when uses both wrapped PEFT and DeepSpped #1400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions optimum/habana/sentence_transformers/st_gaudi_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,8 @@ def compute_loss(
and model != self.model # Only if the model is wrapped
and hasattr(loss_fn, "model") # Only if the loss stores the model
and loss_fn.model != model # Only if the wrapped model is not already stored
and hasattr(model, "module")
and loss_fn.model != model.module # wrapped model differs from orig model
):
loss_fn = self.override_model_in_loss(loss_fn, model)
loss = loss_fn(features, labels)
Expand Down