Fix local variable 'image_features' referenced before assignment#1383
Merged
regisss merged 1 commit intoOct 1, 2024
Merged
Conversation
regisss
approved these changes
Oct 1, 2024
Collaborator
regisss
left a comment
There was a problem hiding this comment.
LGTM!
We could also add
image_hidden_states=image_features if pixel_values is not None and input_ids.shape[1] != 1 else None,in the output, but it may not cover every case.
alekseyfa
pushed a commit
to alekseyfa/optimum-habana
that referenced
this pull request
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR fixes the following tests:
Failure:
Issue comes from transformers: huggingface/transformers@9c4639b#diff-2204a446d82a75771bf0df20c493c6b6cdfba7a87e51767ac63aa9cf8832100aR555
image_featuresis set inside an if statement and the tests fails as they don't enter it.Verify outputs/functional accuracy test
Regressions on transformers_future + this PR
Fixes # (issue)
Before submitting