Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
schoi-habana
added a commit
that referenced
this pull request
Mar 21, 2024
xin3he
pushed a commit
to xin3he/optimum-habana
that referenced
this pull request
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CI workflows' jobs currently use
if: ${{ always() }}so that all jobs are always executed (even if previous jobs failed). However, with this conditional statement, jobs are not cancellable (see here). This is annoying when the self-hosted runner cannot be found (for example because it could not be created when no DL1 instance is available on AWS) because in that case the job can spend days looking for the runner (see here) while it can not be manually cancelled. This issue has been discussed here, here and here.The suggested workaround is to use the status check functions
success,failureandcancelled.Before submitting