Skip to content

Replace always() in CI workflows#104

Merged
regisss merged 1 commit into
mainfrom
ci_tweak
Sep 25, 2022
Merged

Replace always() in CI workflows#104
regisss merged 1 commit into
mainfrom
ci_tweak

Conversation

@regisss
Copy link
Copy Markdown
Collaborator

@regisss regisss commented Sep 23, 2022

What does this PR do?

CI workflows' jobs currently use if: ${{ always() }} so that all jobs are always executed (even if previous jobs failed). However, with this conditional statement, jobs are not cancellable (see here). This is annoying when the self-hosted runner cannot be found (for example because it could not be created when no DL1 instance is available on AWS) because in that case the job can spend days looking for the runner (see here) while it can not be manually cancelled. This issue has been discussed here, here and here.

The suggested workaround is to use the status check functions success, failure and cancelled.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Sep 23, 2022

The documentation is not available anymore as the PR was closed or merged.

@regisss regisss merged commit f6c6b4a into main Sep 25, 2022
@regisss regisss deleted the ci_tweak branch September 25, 2022 18:48
schoi-habana added a commit that referenced this pull request Mar 21, 2024
xin3he pushed a commit to xin3he/optimum-habana that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants