Re: Major refactoring #36 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyasMoutawwakil
changed the title
Member
Author
|
I found out my GPU and ORT Training tests (exit code) are not propagated to the workflow 😅 probably because they're launched through a script or docker. I'll fix them in another PR. I was launching them locally each time before pushing so I never noticed until now. |
IlyasMoutawwakil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36 didn't fully solve the
CUDA_VISIBLE_DEVICES#27 issue because I ended up relying on torch for device handling and third party packages imported it anyways.This should do it. I will also add a test later that checks
CUDA_VISIBLE_DEVICESis respected when passed in config.Edit: At the end it was mostly
optimum.exportersthat imported torch whenTasksManageris imported.