-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix LightEval commands and dependencies #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
|
||
```shell | ||
uv venv openr1 --python 3.11 && source openr1/bin/activate && uv pip install --upgrade pip --link-mode=copy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This --link-mode
flag is a bit specific to the HF cluster and can be resolved by adding export UV_LINK_MODE=copy
to ones .bashrc
file.
```shell | ||
uv pip install vllm==0.7.2 --link-mode=copy | ||
uv pip install vllm==0.7.2 | ||
uv pip install setuptools && uv pip install flash-attn --no-build-isolation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to rebuild the env on the cluster and realised we need this --no-build-isolation
flag that can be accessed with editable installs. Thus we need to pre-install FA2 before running the editable install
README.md
Outdated
|
||
```shell | ||
GIT_LFS_SKIP_SMUDGE=1 uv pip install -e ".[dev]" --link-mode=copy | ||
uv pip install -e ".[dev]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By unpinning lighteval
to just run main
we don't need the Git LFS flag
README.md
Outdated
```shell | ||
MODEL=deepseek-ai/DeepSeek-R1-Distill-Qwen-1.5B | ||
MODEL_ARGS="pretrained=$MODEL,dtype=bfloat16,max_model_length=32768,gpu_memory_utilisation=0.8" | ||
MODEL_ARGS="pretrained=$MODEL,dtype=bfloat16,max_model_length=32768,gpu_memory_utilization=0.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo fix needed with latest version of LightEval: huggingface/lighteval#553
setup.py
Outdated
"latex2sympy2_extended>=1.0.6", | ||
"liger_kernel==0.5.2", | ||
"lighteval @ git+https://github.com/huggingface/lighteval.git@86f62259f105ae164f655e0b91c92a823a742724#egg=lighteval[math]", | ||
"lighteval @ git+https://github.com/huggingface/lighteval.git@e89a9876ada1da511df0708955a63012739222b5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important fix for generation parameter parsing: huggingface/lighteval#578
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe add instructions for export UV_LINK_MODE=copy
to ones .bashrc file for HF users?
* Fix lighteval cmd * Fix typo * Pin lighteval * Hacks to the max * Fix slurm * Fix * Pin lighteval * Pin l --------- Co-authored-by: [email protected] <[email protected]>
Merge after: huggingface/lighteval#578