position ids for kv-cache #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this differ from @ariG23498 's PR (#69)? Did you test it with the benchmark scripts if there is a noticeable speedup? |
|
Shouldn't we put it in the same PR then? Or is is also a general fix? I am a bit confused what exactly it does |
|
I didn't have permissions, so I made a PR on the PR... sorry about the confusion. It adds the position_id so that the rope position embeddings are added correctly, and then we sample a new token sequentially using the kv-cache up till the max_new_token lengths in the generate |
|
@ariG23498 will test it out in the morning I believe |
|
Ah okay, I see. I added you to the repo though, you should have permission! |
ariG23498
approved these changes
May 23, 2025
sang-nguyen-ts
pushed a commit
to tsdocode/nanoVLM
that referenced
this pull request
May 28, 2025
* position ids for rope * cleanup * no need for mask * no mask * more cleanup * add back filtering * more cleanup * revert the signature of llm's generate and forward * use self.decoder.lm_use_tokens * use torch inference_mode * add back comment * fix bug * add back comments * add back comments
pgryko
pushed a commit
to pgryko/nanoVLM
that referenced
this pull request
Jul 6, 2025
* position ids for rope * cleanup * no need for mask * no mask * more cleanup * add back filtering * more cleanup * revert the signature of llm's generate and forward * use self.decoder.lm_use_tokens * use torch inference_mode * add back comment * fix bug * add back comments * add back comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.