Skip to content

Conversation

NathanHB
Copy link
Member

@NathanHB NathanHB commented Mar 6, 2024

No description provided.

@NathanHB NathanHB linked an issue Mar 6, 2024 that may be closed by this pull request
@NathanHB NathanHB requested a review from clefourrier March 7, 2024 09:26
@clefourrier
Copy link
Member

I don't think that's what you need to change (but I could have misunderstood the problem). It was removing the overall all key with the averages that is the problem, right?

If yes, you'll need to add back some of the code from this PR - notably

self.metric_aggregated["all"] = suite_average

and the versions init

Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cf previous comment - feel free to ping me if you need more pointers

@clefourrier
Copy link
Member

Was tested by @shaltielshmid for another PR, and works fine, merging

@clefourrier clefourrier merged commit b1aa626 into main Mar 19, 2024
hynky1999 pushed a commit that referenced this pull request May 22, 2025
---------

Co-authored-by: Clémentine Fourrier <[email protected]>
Co-authored-by: [email protected] <[email protected]>
NathanHB added a commit that referenced this pull request Sep 19, 2025
---------

Co-authored-by: Clémentine Fourrier <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push details to hub does not work

2 participants