-
Notifications
You must be signed in to change notification settings - Fork 362
Upgrade to datasets 4.0 #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
clefourrier
approved these changes
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - did you test it manually on a couple custom tasks?
Doing the tests right now, will ping when ready :) |
NathanHB
added a commit
that referenced
this pull request
Sep 19, 2025
* remove trust remote code for datasets and bump datasets to 4.0 * remove trust remote code for datasets in extended tasks * remove trust remote code for datasets in multilingual tasks * fixing tasks for datasets 4.0 * fixing custom task loading to be compatible with datasets 4.0 * fix lcb * revert main_tasks.py * revert registry.py * raise instead of assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verified on:
Also tried to load all tasks (multilingual included), and opened PRs to datasets that needed conversion to parquet. Those might not be merged yet, I merged all the ones that were under
lighteval
and moved some tolighteval
to merge them directly (lcb has been moved tolighteval
org).