Tidy up dependency groups #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewtun
commented
Mar 2, 2024
lewtun
commented
Mar 2, 2024
lewtun
commented
Mar 2, 2024
clefourrier
reviewed
Mar 4, 2024
lewtun
commented
Mar 4, 2024
lewtun
commented
Mar 4, 2024
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
--------- Co-authored-by: Nathan Habib <[email protected]> Co-authored-by: Clémentine Fourrier <[email protected]>
NathanHB
pushed a commit
that referenced
this pull request
Sep 19, 2025
--------- Co-authored-by: Nathan Habib <[email protected]> Co-authored-by: Clémentine Fourrier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganises the dependency groups so that things like
ruffandpytestare not part of the core library. This is how we do it in the other HF libs and is important because when these utilities are pinned to specific versions, it is not simple to integratelightevalwithin another codebase / environment where the versions can clash.One added bonus, is that one can now just define:
pip install -e '.[dev]'to get the core set of dependencies during development :)