Nathan unify modelargs #609
Merged
+710
−1,289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eval into nathan-unify-modelargs
NathanHB
commented
Apr 8, 2025
| padding_side="left", | ||
| truncation_side="left", | ||
| ) | ||
| except FileNotFoundError: |
There was a problem hiding this comment.
this should not be needed as it is an issue with tokenizer version or config
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
NathanHB
commented
Apr 8, 2025
clefourrier
approved these changes
Apr 10, 2025
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
- removed override batch size and made it part of model config - remove env config, config should be part of env directly, no need to load it up - better loading of models - baseclass for model configs, allows parsing of model config through cli or config file. - Unified naming for model args, i.e. `model_name` - removed openai endpoint, we can just use litellm for this, same for TGI and inference endpoints we don't really need it and it's better to have one interface
|
see: #857 |
NathanHB
added a commit
that referenced
this pull request
Sep 19, 2025
- removed override batch size and made it part of model config - remove env config, config should be part of env directly, no need to load it up - better loading of models - baseclass for model configs, allows parsing of model config through cli or config file. - Unified naming for model args, i.e. `model_name` - removed openai endpoint, we can just use litellm for this, same for TGI and inference endpoints we don't really need it and it's better to have one interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
model_name