Skip to content

Parse string values for add_special_tokens in vLLM #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

Parse string values for add_special_tokens in vLLM #598

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e991cb5
parse string values for add_special_tokens
eldarkurtic Mar 3, 2025
d6058f0
fix style
eldarkurtic Mar 4, 2025
0f3050c
Merge branch 'main' into fix-add-special-token-parsing
eldarkurtic Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lighteval/models/vllm/vllm_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,11 @@ def __init__(
self.data_parallel_size = int(config.data_parallel_size)
self.tensor_parallel_size = int(config.tensor_parallel_size)

self._add_special_tokens = config.add_special_tokens if config.add_special_tokens is not None else False
self._add_special_tokens = (
config.add_special_tokens
if isinstance(config.add_special_tokens, bool)
else str(config.add_special_tokens).lower() == "true"
)
self._tokenizer = self._create_auto_tokenizer(config, env_config)

self._max_length = int(config.max_model_length) if config.max_model_length is not None else None
Expand Down