-
Notifications
You must be signed in to change notification settings - Fork 358
Math extraction - allow only trying the first match, more customizable latex extraction + bump deps #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Clémentine Fourrier <[email protected]>
Co-authored-by: Clémentine Fourrier <[email protected]>
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
clefourrier
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Feel free to merge once tests pass! |
hynky1999
added a commit
that referenced
this pull request
May 22, 2025
…e latex extraction + bump deps (#522) * extract matching * better docstring * lazy imports * bump up math * Update src/lighteval/metrics/dynamic_metrics.py Co-authored-by: Clémentine Fourrier <[email protected]> * fix pr commnets * Apply suggestions from code review Co-authored-by: Clémentine Fourrier <[email protected]> * rename comparisson -> comparison * fix expr numbers extraction with currency or units * add test for correct extraction of failed answer * bump of latex2sympy2 version, add new tests for extract metric * bump up latex2sympy + adjust latex target * revert gold target timoeut * remove dead comment 💀 * add doc --------- Co-authored-by: Clémentine Fourrier <[email protected]>
NathanHB
pushed a commit
that referenced
this pull request
Sep 19, 2025
…e latex extraction + bump deps (#522) * extract matching * better docstring * lazy imports * bump up math * Update src/lighteval/metrics/dynamic_metrics.py Co-authored-by: Clémentine Fourrier <[email protected]> * fix pr commnets * Apply suggestions from code review Co-authored-by: Clémentine Fourrier <[email protected]> * rename comparisson -> comparison * fix expr numbers extraction with currency or units * add test for correct extraction of failed answer * bump of latex2sympy2 version, add new tests for extract metric * bump up latex2sympy + adjust latex target * revert gold target timoeut * remove dead comment 💀 * add doc --------- Co-authored-by: Clémentine Fourrier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^title