Skip to content

Conversation

JoelNiklaus
Copy link
Contributor

Noticed an issue with the ModelResponse in PR #485

@JoelNiklaus
Copy link
Contributor Author

@clefourrier Sorry, i only noticed this issue now. But this should fix it.

@clefourrier
Copy link
Member

Will merge once tests pass, thanks for the fix

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@JoelNiklaus
Copy link
Contributor Author

Sorry, I was a bit confused before. It should return a string and not a ModelResponse.

@JoelNiklaus
Copy link
Contributor Author

Now it should be ready, sorry for the hassle.

@clefourrier clefourrier merged commit fee2ec3 into huggingface:main Jan 20, 2025
3 checks passed
hynky1999 pushed a commit that referenced this pull request May 22, 2025
* Made litellm judge backend more robust.

* Added failed flag to ModelResponse.

* Fixed wrong model response.

* Removed model response and replaced with string.

---------

Co-authored-by: Clémentine Fourrier <[email protected]>
NathanHB pushed a commit that referenced this pull request Sep 19, 2025
* Made litellm judge backend more robust.

* Added failed flag to ModelResponse.

* Fixed wrong model response.

* Removed model response and replaced with string.

---------

Co-authored-by: Clémentine Fourrier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants