Skip to content

Fix T_co import bug #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Fix T_co import bug #484

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edfa472
Fix T_co import bug
gucci-j Jan 3, 2025
66934ee
Merge branch 'huggingface:main' into fix-tco
gucci-j Jan 7, 2025
06d412b
Fix styling
gucci-j Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/lighteval/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,15 @@
from typing import Iterator, Tuple

import torch
from packaging import version
from torch.utils.data import Dataset
from torch.utils.data.distributed import DistributedSampler, T_co


if version.parse(torch.__version__) >= version.parse("2.5.0"):
from torch.utils.data.distributed import DistributedSampler, _T_co
else:
from torch.utils.data.distributed import DistributedSampler
from torch.utils.data.distributed import T_co as _T_co

from lighteval.tasks.requests import (
GreedyUntilRequest,
Expand Down Expand Up @@ -318,7 +325,7 @@ class GenDistributedSampler(DistributedSampler):
as our samples are sorted by length.
"""

def __iter__(self) -> Iterator[T_co]:
def __iter__(self) -> Iterator[_T_co]:
if self.shuffle:
# deterministically shuffle based on epoch and seed
g = torch.Generator()
Expand Down
Loading