Quickfix: repeated vllm model cleanup when data_parallel_size>1 #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR ! I'm pretty sure that in data // mode, each process has it's own model so it should not be an issue. Did you run into an issue were the model was already deleted ? |
|
@NathanHB yes, I catch an error there due to the model already being None. It only happens with |
|
Ohh I did not take vllm // into account, it indeed works deifferently, good catch ! |
NathanHB
approved these changes
Nov 19, 2024
JoelNiklaus
pushed a commit
to JoelNiklaus/lighteval
that referenced
this pull request
Nov 25, 2024
Co-authored-by: Nathan Habib <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
Nov 29, 2024
Co-authored-by: Nathan Habib <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
Co-authored-by: Nathan Habib <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
Co-authored-by: Nathan Habib <[email protected]>
NathanHB
added a commit
that referenced
this pull request
Sep 19, 2025
Co-authored-by: Nathan Habib <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup seems to be called from multiple processes in data parallel mode, so this just ensures there's no error due to the already deleted model object.