Nanotron greedy_until() fix #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelNiklaus
pushed a commit
to JoelNiklaus/lighteval
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Nathan Habib <[email protected]> Co-authored-by: Clémentine Fourrier <[email protected]>
Merged
hynky1999
pushed a commit
that referenced
this pull request
Nov 29, 2024
Co-authored-by: Nathan Habib <[email protected]> Co-authored-by: Clémentine Fourrier <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
Co-authored-by: Nathan Habib <[email protected]> Co-authored-by: Clémentine Fourrier <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
Co-authored-by: Nathan Habib <[email protected]> Co-authored-by: Clémentine Fourrier <[email protected]>
NathanHB
added a commit
that referenced
this pull request
Sep 19, 2025
Co-authored-by: Nathan Habib <[email protected]> Co-authored-by: Clémentine Fourrier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluating a nanotron checkpoint on a benchmark with a GreedyUntil request crashes with the following error message:
There is a bug in
max_gen = max(item[1].generation_size for item in dataset)becausedatasetisGenerativeTaskDatasetNanotronwhose__iter__()yields items directly without the index. This PR works around the issue ingreedy_until()for the nanotron model.