-
Notifications
You must be signed in to change notification settings - Fork 358
refacto judge and add mixeval #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanHB
commented
Sep 30, 2024
…gingface/lighteval into nathan-refacto-judge-and-add-mixeval
…gingface/lighteval into nathan-refacto-judge-and-add-mixeval
clefourrier
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but you need some changes - super nice overalll refacto!
Closed
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
What this PR does: - [x] Adds MixEval task - add a mixeval judge as a sample metric using the new LLMJudge metric - [x] refactor the judge metric - easier to define judges for custom tasks - [x] now batches the model restuls per tasks and then per metric type to be computed in batch (does not change anything for tasks other than llm as judge which is now much faster) --------- Co-authored-by: Clémentine Fourrier <[email protected]>
NathanHB
added a commit
that referenced
this pull request
Sep 19, 2025
What this PR does: - [x] Adds MixEval task - add a mixeval judge as a sample metric using the new LLMJudge metric - [x] refactor the judge metric - easier to define judges for custom tasks - [x] now batches the model restuls per tasks and then per metric type to be computed in batch (does not change anything for tasks other than llm as judge which is now much faster) --------- Co-authored-by: Clémentine Fourrier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: