Skip to content

Conversation

chuandudx
Copy link
Contributor

Minor typo fix.

Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ^^"

@chuandudx
Copy link
Contributor Author

chuandudx commented Sep 24, 2024

Hi Clémentine, thanks for all the reviews! I've noticed all my PRs have failed so far and for both here and #309 they are due to

=========================== short test summary info ============================
FAILED tests/logging/test_evaluation_tracker.py::test_push_to_hub_works - huggingface_hub.errors.HfHubHTTPError: 401 Client Error: Unauthorized for url: https://huggingface.co/api/repos/create (Request ID: Root=1-66f17961-2ccc19c01db6ef4e27524e0c;d58482d9-737c-42c7-9fe6-8a76a7e62bc8)

Invalid username or password.

Previously I never did this step:
huggingface-cli login

Now when I run huggingface-cli whoami the output is chuandudx.

I have just fixed another minor typo here and re-committed after feeding in my HF_TOKEN.

Do you think we could re-run the tests and whether these are the appropriate steps to follow to make sure the PRs go through correctly? I have also made sure to now install the precommit hook for styling tests. Please let me know if there are other guidelines I can review to make sure these are according to style requirements :)

@clefourrier
Copy link
Member

The README was edited and reduced considerably, I think those are now in the wiki - I'm closing, feel free to open an issue on the wiki if we still have the typo there!

@chuandudx
Copy link
Contributor Author

Yess, I love the new wiki! I made the changes directly there :) thank you!
https://github.com/huggingface/lighteval/wiki/Metric-List

@chuandudx chuandudx deleted the readme-access-key branch September 27, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants