Allow kwargs for BERTScore compute function and remove unused var #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefourrier
reviewed
Sep 16, 2024
clefourrier
reviewed
Sep 16, 2024
clefourrier
reviewed
Sep 16, 2024
…val into generative_metric_error
clefourrier
approved these changes
Sep 17, 2024
|
I checked the failure and saw user authentication related error - is this something related to any configurations I have? |
|
Updated branch and doubled checked for style issues :) |
NathanHB
added a commit
that referenced
this pull request
Oct 16, 2024
These changes address the issues described in: #315 I made the code changes such that it built on the BERTScore changes (#311) that haven't been merged yet, so we see those changes here. Please let me know if there is preference on removing those from this PR. Thank you! --------- Co-authored-by: Clémentine Fourrier <[email protected]> Co-authored-by: Nathan Habib <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
* Keep recale_with_baseline as True by default for existing users. --------- Co-authored-by: Clémentine Fourrier <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
These changes address the issues described in: #315 I made the code changes such that it built on the BERTScore changes (#311) that haven't been merged yet, so we see those changes here. Please let me know if there is preference on removing those from this PR. Thank you! --------- Co-authored-by: Clémentine Fourrier <[email protected]> Co-authored-by: Nathan Habib <[email protected]>
NathanHB
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Keep recale_with_baseline as True by default for existing users. --------- Co-authored-by: Clémentine Fourrier <[email protected]>
NathanHB
added a commit
that referenced
this pull request
Sep 19, 2025
These changes address the issues described in: #315 I made the code changes such that it built on the BERTScore changes (#311) that haven't been merged yet, so we see those changes here. Please let me know if there is preference on removing those from this PR. Thank you! --------- Co-authored-by: Clémentine Fourrier <[email protected]> Co-authored-by: Nathan Habib <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses items 1 and 3 in this issue: #310. Thank you in advance for your feedback.
I also am curious if there is an easier way to set
rescale_with_baselineif we don't do it directly within this file.Thanks!