Skip to content

Conversation

@srossi93
Copy link

@srossi93 srossi93 commented Sep 5, 2024

fix(accelerate): Fix missing model_config_path when creating model config

The argument model_config_path was never passed when creating the model_config.

…nfig

The argument `model_config_path` was never passed when creating the `model_config`.
@srossi93
Copy link
Author

Pinging @hynky1999;
The failure of the CI doesn't seem to be related to the content of this PR. Could you please check?

@hynky1999
Copy link
Collaborator

hynky1999 commented Sep 13, 2024

Seems like the secrets are not exposed for user PRs (which make sense from security perspecity) for some reason even tho manually approved. I will check what we can do with it.

Update:
No way around this dumb restriction, I will skip the test if the secret is not provided

@srossi93
Copy link
Author

@clefourrier
Why was this closed unmerged? #304 fixes a problem with the checks but it doesn’t fix the content of this PR.

@clefourrier
Copy link
Member

clefourrier commented Sep 16, 2024

Hi! This was done automatically by github, let me check why.
Edit: the issue you're having was indeed fixed by another PR I merged yesterday evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants