Skip to content

Fixes #165 - adds a check with generation length is not set by the user #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Fixes #165 - adds a check with generation length is not set by the user #233

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
910f2bb
fix
clefourrier Jul 18, 2024
aa18dbf
Merge branch 'main' into #165
NathanHB Jul 18, 2024
0e3a399
Merge branch 'main' into #165
NathanHB Jul 23, 2024
987d849
Merge branch 'main' into #165
NathanHB Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lighteval/models/base_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,10 @@ def greedy_until(
# There will be truncation of at least one sample, maximum generation size will be one
max_new_tokens = 1
else: # We can't allow generation of more than max_length
max_new_tokens = min(self.max_length - context_size, max_new_tokens)
if max_new_tokens is None: # If generation size is not set, we go all the way
max_new_tokens = self.max_length - context_size
else:
max_new_tokens = min(self.max_length - context_size, max_new_tokens)

prepared_batch = Batch(
input_ids=tokenized["input_ids"],
Expand Down