Updated tgi_model and added parameters for endpoint_model #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefourrier
reviewed
Jul 3, 2024
clefourrier
approved these changes
Jul 3, 2024
|
Can you fix the style using ruff too? |
|
Done! Please let me know what you think of the additions to the README. |
|
This is great, thank you! |
hynky1999
pushed a commit
to hynky1999/lighteval
that referenced
this pull request
Jul 12, 2024
…e#208) * Added image url parameter * Fixed up tgi model config * Undid tgi available check * Adjust tgi parameter names, and checked for attr existence * Fixed task Id in argparse * Removed obfuscation from private functions, to allow inheritance to override * Updated tgi model to inherit from endpoint and just modify client calls * Added option to specify model id in config for tgi model * Added option to specify custom env vars * Updated env vras * Applied ruff format * Added docs + readme * Ruff format
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
* Added image url parameter * Fixed up tgi model config * Undid tgi available check * Adjust tgi parameter names, and checked for attr existence * Fixed task Id in argparse * Removed obfuscation from private functions, to allow inheritance to override * Updated tgi model to inherit from endpoint and just modify client calls * Added option to specify model id in config for tgi model * Added option to specify custom env vars * Updated env vras * Applied ruff format * Added docs + readme * Ruff format
NathanHB
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Added image url parameter * Fixed up tgi model config * Undid tgi available check * Adjust tgi parameter names, and checked for attr existence * Fixed task Id in argparse * Removed obfuscation from private functions, to allow inheritance to override * Updated tgi model to inherit from endpoint and just modify client calls * Added option to specify model id in config for tgi model * Added option to specify custom env vars * Updated env vras * Applied ruff format * Added docs + readme * Ruff format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1] Updated tgi_model to inherit from LightevalModel, including implementing all the abstract properties. Since the TGIClient and the InferenceClient produce the same format (since they both use TGI), I had TGIClient inherit from InferenceClient, and then just override the functions that use the client. In order to do that, I had to update the private functions in InferenceClient to use one underscore so the names aren't obfuscated.
2] Added two optional fields to the endpoint_model config - specifying the image_url and allowing for any other environment variables. This will allow users to update to later versions of the TGI container without having to rebuild, or to specify other properties like max_input_tokens.