Add maj@k metric #158
Merged
Add maj@k metric #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewtun
reviewed
Apr 18, 2024
lewtun
reviewed
Apr 18, 2024
NathanHB
reviewed
Apr 20, 2024
NathanHB
previously approved these changes
Apr 21, 2024
|
I'll check it - however, please don't merge yet, I need to propagate the changes to the other lauchers + simplify greedy :) |
…ls in one single step
|
Oh mb I thought it ready for review ! |
|
I hope I'll finish it today :) |
clefourrier
commented
Apr 22, 2024
|
Tests failing because of the hub problems ^^""" |
clefourrier
force-pushed
the
add_maj_at_k
branch
from
e45f395 to
4ef4c99
Compare
NathanHB
reviewed
Apr 22, 2024
NathanHB
reviewed
Apr 22, 2024
NathanHB
reviewed
Apr 22, 2024
NathanHB
approved these changes
Apr 22, 2024
Co-authored-by: Nathan Habib <[email protected]>
Closed
|
Is this good to be merged ? I saw on slack you did not get the same results for mistral models. (do we even know how they ran their tests ?) |
|
I'll do more tests today - we could merge it now and adjust later if needed though. |
|
Alright i'm merging it so that we can merge the other PRs |
NathanHB
added a commit
that referenced
this pull request
Jul 11, 2024
This PR needs #158 to be merged first. The main problem is that splits are no longer by size, but they are however now making sure that all batched generative evals are launched with similar evals (same sampling, same eos tokens) --------- Co-authored-by: Nathan Habib <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
Co-authored-by: Nathan Habib <[email protected]> * added review change --------- Co-authored-by: Nathan Habib <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
This PR needs #158 to be merged first. The main problem is that splits are no longer by size, but they are however now making sure that all batched generative evals are launched with similar evals (same sampling, same eos tokens) --------- Co-authored-by: Nathan Habib <[email protected]>
NathanHB
added a commit
that referenced
this pull request
Sep 19, 2025
Co-authored-by: Nathan Habib <[email protected]> * added review change --------- Co-authored-by: Nathan Habib <[email protected]>
NathanHB
added a commit
that referenced
this pull request
Sep 19, 2025
This PR needs #158 to be merged first. The main problem is that splits are no longer by size, but they are however now making sure that all batched generative evals are launched with similar evals (same sampling, same eos tokens) --------- Co-authored-by: Nathan Habib <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still missing: