Added Namespace parameter for InferenceEndpoints, added option for passing model config directly #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanHB
reviewed
Apr 8, 2024
NathanHB
reviewed
Apr 8, 2024
NathanHB
reviewed
Apr 8, 2024
|
Great!! |
|
Thanks for the comments! Added in the doc strings :) |
NathanHB
approved these changes
Apr 10, 2024
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
…ssing model config directly (#147) 1] I added the `namespace` parameter to the endpoint model config, to allow deploying endpoints from an organization that isn't your private user. - Added the namespace property to the class - Added a static method `nullable_keys()` so that the check for a complete config when creating the endpoint can ignore those. 2] I added the option to specify the model config directly from python code, with a simple check to see if it was given. (Note: I unindented everything after the `yaml.safe_load`, since after the yaml was loaded there was no need to remain inside the scope of accessing the file). --------- Co-authored-by: Clémentine Fourrier <[email protected]>
NathanHB
pushed a commit
that referenced
this pull request
Sep 19, 2025
…ssing model config directly (#147) 1] I added the `namespace` parameter to the endpoint model config, to allow deploying endpoints from an organization that isn't your private user. - Added the namespace property to the class - Added a static method `nullable_keys()` so that the check for a complete config when creating the endpoint can ignore those. 2] I added the option to specify the model config directly from python code, with a simple check to see if it was given. (Note: I unindented everything after the `yaml.safe_load`, since after the yaml was loaded there was no need to remain inside the scope of accessing the file). --------- Co-authored-by: Clémentine Fourrier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1] I added the
namespaceparameter to the endpoint model config, to allow deploying endpoints from an organization that isn't your private user.nullable_keys()so that the check for a complete config when creating the endpoint can ignore those.2] I added the option to specify the model config directly from python code, with a simple check to see if it was given. (Note: I unindented everything after the
yaml.safe_load, since after the yaml was loaded there was no need to remain inside the scope of accessing the file).Sending you sample code to test on slack.