Skip to content

Reorder addition of instruction in chat template #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Reorder addition of instruction in chat template #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/lighteval/few_shot_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,12 @@ def get_examples_with_chat_template(
examples.append({"role": "assistant", "content": task.doc_to_target(ex)})
# We add the actual example
examples.append({"role": "user", "content": example})
# We add the initial instruction if present
examples[0]["content"] = instruction + examples[0]["content"]
# We add the initial instruction if present, after the system prompt of before the task
if examples[0]["role"] == "system":
examples[0]["content"] = examples[0]["content"] + instruction
else:
examples[0]["content"] = instruction + examples[0]["content"]

return tokenizer.apply_chat_template(examples, tokenize=False, add_generation_prompt=True)

def get_examples(
Expand Down