-
Notifications
You must be signed in to change notification settings - Fork 359
Adding TinyBench #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TinyBench #104
Conversation
|
||
@staticmethod | ||
def corpus_level_fns() -> dict[str, callable]: | ||
def corpus_level_fns(metrics: list[str]) -> dict[str, callable]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this fix, we were overwritting the aggregations! (which was never a problem since we tend to use the same aggregation for similar evals, like np.mean for acc)
# SOFTWARE. | ||
|
||
# ruff: noqa: F405, F403, F401 | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe good to add your sample usage command here? Otherwise it's hard for users to know how to run it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, thanks for the edit!
I'm getting this error when running the command in the description:
|
|
* Edited mechanism for corpus aggregations using dict * very important bug fix on aggregation call!
* Edited mechanism for corpus aggregations using dict * very important bug fix on aggregation call!
Should be good to review.
Test with: