refactor(teleop): Use queue instead of locks for keyboard teleop #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliberts
approved these changes
Mar 22, 2025
Collaborator
aliberts
left a comment
aliberts
left a comment
There was a problem hiding this comment.
LGTM, left a suggestion to improve clarity. Thanks!
imstevenpmwork
force-pushed
the
feat/thread_safe_teleop_keyboard_queue
branch
from
475ed2c to
75c7877
Compare
imstevenpmwork
merged commit ccad5d9
into
feat/thread_safe_teleop_keyboard
5 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Replaces lock mechanism with a queue for the keyboard tele implementation
This is meant to be squash & merge