Skip to content

Comments

Fix typos in lerobot/scripts/visualize_dataset.py#656

Merged
Cadene merged 1 commit intohuggingface:mainfrom
tc-huang:fix-typo-visualize-dataset
Jan 28, 2025
Merged

Fix typos in lerobot/scripts/visualize_dataset.py#656
Cadene merged 1 commit intohuggingface:mainfrom
tc-huang:fix-typo-visualize-dataset

Conversation

@tc-huang
Copy link
Contributor

What this does

This commit addresses several typos in lerobot/scripts/visualize_dataset.py:

  • "doesnt" → "doesn't" (line 18)
  • "lossly" → "lossy" (line 25)
  • "repositery" → "repository" (line 202)

How it was tested

  • Ran python lerobot/scripts/visualize_dataset.py --repo-id lerobot/pusht --episode-index 0 locally to verify everything still works.
  • Ran the test case of lerobot/scripts/visualize_dataset.py by running pytest tests/test_visualize_dataset.py.
    • However, the test function test_visualize_local_dataset is currently skipped via @pytest.mark.skip("TODO: add dummy videos"). The test file still ensures that we can import the relevant modules by from lerobot.scripts.visualize_dataset import visualize_dataset without error.

How to checkout & try? (for the reviewer)

  • You can review the updated docstrings and help texts to ensure the spelling corrections are properly applied.
  • python lerobot/scripts/visualize_dataset.py --repo-id lerobot/pusht --episode-index 0
  • pytest tests/test_visualize_dataset.py

…text

This commit addresses several typos in the script:
- "repositery" → "repository"
- "doesnt" → "doesn't"
- "lossly" → "lossy"
@Cadene Cadene enabled auto-merge (squash) January 27, 2025 16:10
@Cadene
Copy link
Contributor

Cadene commented Jan 27, 2025

Thanks!

@Cadene Cadene merged commit 5daa454 into huggingface:main Jan 28, 2025
5 checks passed
@tc-huang
Copy link
Contributor Author

@Cadene Thank you for approving my first-ever contribution to this great community. Your review means a lot to me!

@tc-huang tc-huang deleted the fix-typo-visualize-dataset branch January 28, 2025 12:23
menhguin pushed a commit to menhguin/lerobot that referenced this pull request Feb 9, 2025
JIy3AHKO pushed a commit to vertix/lerobot that referenced this pull request Feb 27, 2025
ZoreAnuj pushed a commit to luckyrobots/lerobot that referenced this pull request Jul 29, 2025
Ricci084 pushed a commit to JeffWang987/lerobot that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants