Update robot examples with draccus commands #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadene
changed the base branch from
main
to
user/aliberts/2024_11_30_remove_hydra
…hydra' into user/rcadene/2025_01_25_robot_doc_draccus
…hydra' into user/rcadene/2025_01_25_robot_doc_draccus
aliberts
approved these changes
Jan 28, 2025
Collaborator
aliberts
left a comment
aliberts
left a comment
There was a problem hiding this comment.
Shallow review but LGTM, thanks!
| f"The policy you are trying to load has been trained with use_amp={train_cfg.use_amp} " | ||
| f"but you're trying to evaluate it with use_amp={self.use_amp}" | ||
| ) | ||
| if self.device == "mps" and train_cfg.device == "cuda": |
Collaborator
There was a problem hiding this comment.
Should we still warn in this case?
aliberts
merged commit 214083f
into
user/aliberts/2024_11_30_remove_hydra
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
How it was tested
TODO