Skip to content

Fix --width --height type parsing on opencv and intelrealsense scripts #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imstevenpmwork merged 7 commits into from
Apr 17, 2025
Merged

Fix --width --height type parsing on opencv and intelrealsense scripts #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6f064ab
Fix --width --height type parsing on opencv script
apockill Dec 7, 2024
4abf87e
Merge branch 'main' into bugfix/opencv-script-types
Cadene Dec 8, 2024
897032a
Update `intelrealsense.py` to also parse `--height` and `--width` as …
apockill Dec 9, 2024
f0d7d62
Merge remote-tracking branch 'origin/bugfix/opencv-script-types' into…
apockill Dec 9, 2024
c10d7be
Merge branch 'main' into bugfix/opencv-script-types
apockill Dec 10, 2024
8af3316
Merge branch 'main' into bugfix/opencv-script-types
apockill Jan 3, 2025
18d969a
Merge branch 'main' into bugfix/opencv-script-types
imstevenpmwork Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lerobot/common/robot_devices/cameras/intelrealsense.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,13 +512,13 @@ def __del__(self):
)
parser.add_argument(
"--width",
type=str,
type=int,
default=640,
help="Set the width for all cameras. If not provided, use the default width of each camera.",
)
parser.add_argument(
"--height",
type=str,
type=int,
default=480,
help="Set the height for all cameras. If not provided, use the default height of each camera.",
)
Expand Down
4 changes: 2 additions & 2 deletions lerobot/common/robot_devices/cameras/opencv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,13 +492,13 @@ def __del__(self):
)
parser.add_argument(
"--width",
type=str,
type=int,
default=None,
help="Set the width for all cameras. If not provided, use the default width of each camera.",
)
parser.add_argument(
"--height",
type=str,
type=int,
default=None,
help="Set the height for all cameras. If not provided, use the default height of each camera.",
)
Expand Down