Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds **kwargs parameter to the WallXPolicy.__init__ method to enable passing additional keyword arguments through the initialization chain. While this aims to improve flexibility for future extensibility, the implementation is inconsistent with existing patterns in the codebase.
Key Changes
- Modified
WallXPolicy.__init__signature to accept**kwargs - Updated the superclass
__init__call to forward**kwargs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Yushun Xiang <73413365+YushunXiang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Updated
WallXPolicy.__init__to accept**kwargsand pass them to the superclass initializer, enabling future extensibility.Type / Scope
Summary / Motivation
This pull request introduces a small update to the initialization method of the
WallXPolicyclass to allow passing additional keyword arguments. This change improves flexibility for subclassing and integration.How was this tested
How to run locally (reviewer)
Run the relevant tests:
Run a quick example or CLI (if applicable):
python src/lerobot/scripts/lerobot_train.py \ --dataset.repo_id=your_dataset \ --policy.type=wall_x \ --output_dir=./outputs/wallx_training \ --job_name=wallx_training \ --policy.repo_id=your_repo_id \ --policy.pretrained_name_or_path=x-square-robot/wall-oss-flow \ --policy.prediction_mode=diffusion \ --policy.attn_implementation=eager \ --steps=3000 \ --policy.device=cuda \ --batch_size=32Checklist (required before merge)
pre-commit run -a)pytest)Reviewer notes
@wut19 @pkooij