Skip to content

Comments

bug(gamepad_utils) inverted axis between x and y#1572

Merged
michel-aractingi merged 1 commit intomainfrom
user/michel-aractingi/2025-07-22-bug-gamepad
Jul 22, 2025
Merged

bug(gamepad_utils) inverted axis between x and y#1572
michel-aractingi merged 1 commit intomainfrom
user/michel-aractingi/2025-07-22-bug-gamepad

Conversation

@michel-aractingi
Copy link
Contributor

Inverts the x and y axes in gamepad_utils.py for the GamepadController class that runs on linux

Copilot AI review requested due to automatic review settings July 22, 2025 11:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an axis inversion bug in the GamepadController class for Linux systems where the x and y axes were swapped and incorrectly inverted.

  • Corrects axis assignment by mapping axis 0 to x_input and axis 1 to y_input
  • Removes negative sign from y_input calculation to fix movement direction
  • Updates comments to reflect proper axis mappings

Copy link
Contributor

@AdilZouitine AdilZouitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michel-aractingi michel-aractingi merged commit 835f0ed into main Jul 22, 2025
12 of 15 checks passed
@michel-aractingi michel-aractingi deleted the user/michel-aractingi/2025-07-22-bug-gamepad branch July 22, 2025 12:31
@michel-aractingi michel-aractingi restored the user/michel-aractingi/2025-07-22-bug-gamepad branch July 22, 2025 14:33
@michel-aractingi michel-aractingi deleted the user/michel-aractingi/2025-07-22-bug-gamepad branch July 22, 2025 14:34
milong26 pushed a commit to milong26/lerobot_diy that referenced this pull request Aug 26, 2025
Ricci084 pushed a commit to JeffWang987/lerobot that referenced this pull request Sep 5, 2025
BillmanH pushed a commit to BillmanH/lerobot that referenced this pull request Sep 7, 2025
sandhya-cb pushed a commit to sandhya-cb/lerobot-clutterbot that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants