Skip to content

Comments

style(deprecated method): Remove no longer used get_features_from_robot() function#1560

Merged
imstevenpmwork merged 1 commit intomainfrom
user/CarolinePascal/2025-07-21-remove-deprecated-methods
Jul 21, 2025
Merged

style(deprecated method): Remove no longer used get_features_from_robot() function#1560
imstevenpmwork merged 1 commit intomainfrom
user/CarolinePascal/2025-07-21-remove-deprecated-methods

Conversation

@CarolinePascal
Copy link
Collaborator

What this does

This PR removes the no longer used (and deprecated) get_features_from_robot() function, which has been replaced by hw_to_dataset_features() in lerobot/datasets/utils.py.

How it was tested

N/A

How to checkout & try? (for the reviewer)

N/A

Copilot AI review requested due to automatic review settings July 21, 2025 12:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated get_features_from_robot() function from the datasets utilities module, as it has been superseded by hw_to_dataset_features() and is no longer used in the codebase.

  • Removes the deprecated get_features_from_robot() function that was previously used to extract features from robot configurations
  • Cleans up unused code to improve maintainability

…ot function (replaced by hw_to_dataset_features)
@CarolinePascal CarolinePascal force-pushed the user/CarolinePascal/2025-07-21-remove-deprecated-methods branch from 7ceaf80 to adf623f Compare July 21, 2025 12:46
@imstevenpmwork imstevenpmwork added the enhancement Suggestions for new features or improvements label Jul 21, 2025
@imstevenpmwork imstevenpmwork self-requested a review July 21, 2025 13:00
Copy link
Collaborator

@imstevenpmwork imstevenpmwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imstevenpmwork imstevenpmwork merged commit 9b9f475 into main Jul 21, 2025
10 of 11 checks passed
@imstevenpmwork imstevenpmwork deleted the user/CarolinePascal/2025-07-21-remove-deprecated-methods branch July 21, 2025 17:12
AdilZouitine pushed a commit that referenced this pull request Jul 23, 2025
…ot function (replaced by hw_to_dataset_features) (#1560)
AdilZouitine pushed a commit that referenced this pull request Jul 23, 2025
…ot function (replaced by hw_to_dataset_features) (#1560)
AdilZouitine pushed a commit that referenced this pull request Jul 23, 2025
…ot function (replaced by hw_to_dataset_features) (#1560)
AdilZouitine pushed a commit that referenced this pull request Aug 10, 2025
…ot function (replaced by hw_to_dataset_features) (#1560)
milong26 pushed a commit to milong26/lerobot_diy that referenced this pull request Aug 26, 2025
Ricci084 pushed a commit to JeffWang987/lerobot that referenced this pull request Sep 5, 2025
BillmanH pushed a commit to BillmanH/lerobot that referenced this pull request Sep 7, 2025
sandhya-cb pushed a commit to sandhya-cb/lerobot-clutterbot that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Suggestions for new features or improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants