Fix pi0fast loss not sent to wandb #1502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix types
Collaborator
|
Hi @ben-z ! Small update : we will put this PR on hold for a while, as we first need to bring some sense and coherence in the loss format across policies ( Best, Caroline. |
AdilZouitine
added
bug
Collaborator
|
Closing this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Similar to #1198 , pi0fast's loss is also of type Tensor, which is not accepted by wandb. This PR converts it to a scalar using
.item()How it was tested
Manually ran training and verified that
lossis now visible in the wandb dashboard for pi0fast.How to checkout & try? (for the reviewer)
Train pi0fast (instructions) and observe the loss log in wandb.