Skip to content

Fix SmolVLA loss not sent to wandb #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aliberts merged 3 commits into from
Jun 5, 2025
Merged

Fix SmolVLA loss not sent to wandb #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61f33a8
Fix smolvla loss not sent to wandb
ben-z Jun 4, 2025
cfb0a6c
Print the type of unknown wandb logging metric
ben-z Jun 4, 2025
a9aede6
Revert storing loss lists because lists can't be sent to wandb either
ben-z Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lerobot/common/policies/smolvla/modeling_smolvla.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ def forward(self, batch: dict[str, Tensor], noise=None, time=None) -> dict[str,
# For backward pass
loss = losses.mean()
# For backward pass
loss_dict["loss"] = loss
loss_dict["loss"] = loss.item()
return loss, loss_dict

def prepare_images(self, batch):
Expand Down
2 changes: 1 addition & 1 deletion lerobot/common/utils/wandb_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def log_dict(self, d: dict, step: int, mode: str = "train"):
for k, v in d.items():
if not isinstance(v, (int, float, str)):
logging.warning(
f'WandB logging of key "{k}" was ignored as its type is not handled by this wrapper.'
f'WandB logging of key "{k}" was ignored as its type "{type(v)}" is not handled by this wrapper.'
)
continue
self._wandb.log({f"{mode}/{k}": v}, step=step)
Expand Down
Loading