refactor(cameras): improvements for cameras implementations + tests #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliberts
changed the base branch from
main
to
user/aliberts/2025_02_25_refactor_robots
imstevenpmwork
force-pushed
the
user/aliberts/2025_04_19_refactor_cameras
branch
3 times, most recently
from
de7f422 to
f40fe28
Compare
imstevenpmwork
added
tests
imstevenpmwork
changed the title
imstevenpmwork
force-pushed
the
user/aliberts/2025_04_19_refactor_cameras
branch
4 times, most recently
from
8548f09 to
0615a46
Compare
…, these 3 are now moved to the camera base class, the width and height specified in the config is now the one output by read() methods
…ght from find_cameras utils
…testing opencv + compressed test artefacts
imstevenpmwork
force-pushed
the
user/aliberts/2025_04_19_refactor_cameras
branch
from
edd4fb2 to
95ae568
Compare
imstevenpmwork
force-pushed
the
user/aliberts/2025_04_19_refactor_cameras
branch
from
25a91fc to
b3ebda2
Compare
…opencv camera tests + add camera artefacts in lfs
imstevenpmwork
force-pushed
the
user/aliberts/2025_04_19_refactor_cameras
branch
from
3698d8d to
e790ad7
Compare
Collaborator
|
Moved to: #1108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
TODO
How it was tested
TODO
How to checkout & try? (for the reviewer)
TODO