Enable tqdm progress in cloud environments #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
reviewed
Dec 6, 2024
There was a problem hiding this comment.
Thanks for investigating this @cbensimon. Solution looks ok to me 👍
Could you update this line as well please?
There was a problem hiding this comment.
TIL the nuance between disable=False and disable=None in tqdm.
same comment as @Wauplin about updating src/huggingface_hub/lfs.py#L435. Otherwise looks good to me! thanks @cbensimon!
Co-authored-by: Célina <[email protected]>
|
@Wauplin @hanouticelina done: src/huggingface_hub/lfs.py#L435 has been updated accordingly |
hanouticelina
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud environments usually enable
TQDM_POSITION=-1to disable carriage return and get clean tqdm progress loggingThe idea of this PR is to use this environment variable as a hint to force enabling tqdm progress despite the absence of TTY
This will at least re-enable download progress in Spaces
#2000 follow-up