-
Notifications
You must be signed in to change notification settings - Fork 681
DDUF parser v0.1 #2692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DDUF parser v0.1 #2692
Changes from 29 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
3b533a6
First draft for a DDUF parser
Wauplin 953bbae
write before read
Wauplin d30558b
comments and lint
Wauplin 0f21bd3
forbid nested directoroes
Wauplin b4bf030
gguf typo
Wauplin 1b11f0b
export_from_entries
Wauplin f349cbe
some docs
Wauplin bf7dc84
Update docs/source/en/package_reference/serialization.md
Wauplin 16c3e15
Update src/huggingface_hub/serialization/_dduf.py
Wauplin ba1e6a4
compute data offset without private arg
Wauplin 0546ca1
type annotations
Wauplin 706597e
enforce 1 level of directory only
Wauplin a6588aa
raise correct error DDUFInvalidEntryNameError
Wauplin 947a593
add tests
Wauplin 2881a57
note
Wauplin 2b7baf5
test uncompress
Wauplin 02a9532
Merge branch 'main' into dduf-parser-v0.1
Wauplin c7ce20a
Merge branch 'main' into dduf-parser-v0.1
Wauplin f5f0f25
required model_index.json
Wauplin 0d1045d
Apply suggestions from code review
Wauplin dca1586
use f-string in logs
Wauplin f6bee85
Merge branch 'dduf-parser-v0.1' of github.com:huggingface/huggingface…
Wauplin 157633c
Update docs/source/en/package_reference/serialization.md
Wauplin 5cf560d
remove add_entry_to_dduf
Wauplin e6c62da
new rules: folders in model_index.json + config files in folders
Wauplin 4078626
Merge branch 'dduf-parser-v0.1' of github.com:huggingface/huggingface…
Wauplin 381ac7e
add arg
Wauplin 76265b4
add arg
Wauplin d796252
Update docs/source/en/package_reference/serialization.md
Wauplin 5c2bb63
Update docs/source/en/package_reference/serialization.md
Wauplin 360ddd1
add scheduler config
SunMarc c168e23
scheduler_config
Wauplin 4553f4c
style
Wauplin 6ad29e7
preprocessor_config.json
Wauplin ce2b858
Merge remote-tracking branch 'origtin' into dduf-parser-v0.1
Wauplin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused that this is
pipe.vae.to_json_string()
but then it'spipe.text_encoder.config.to_json_string()
below, but I think it's correct as the vae config is a FrozenDict.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be up for another solution tbh. I just wanted to show that you need to serialize things as bytes by yourself.