Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝Translating docs to Simplified Chinese #2689

Merged
merged 4 commits into from
Dec 4, 2024
Merged

📝Translating docs to Simplified Chinese #2689

merged 4 commits into from
Dec 4, 2024

Conversation

miaowumiaomiaowu
Copy link
Contributor

#1915
I have translated "search.md" into Simplified Chinese. 😊

@miaowumiaomiaowu miaowumiaomiaowu mentioned this pull request Dec 3, 2024
Open
18 tasks
stevhliu
stevhliu reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution! Do you know another contributor who would be interested in reviewing your translation?

@miaowumiaomiaowu
Copy link
Contributor Author

@stevhliu Thanks for the feedback! I believe @13579606 would be a great person to review this translation. @13579606, would you be able to help with reviewing?

13579606
13579606 approved these changes Dec 4, 2024
View reviewed changes
Copy link

@13579606 13579606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @miaowumiaomiaowu .Here are some suggestions for the translation, don't hesitate to drop me a message if needed.

docs/source/cn/guides/search.md Outdated Show resolved Hide resolved
docs/source/cn/guides/search.md Outdated Show resolved Hide resolved
@miaowumiaomiaowu
Copy link
Contributor Author

Hi @13579606 ,
Thank you so much for your thorough review and valuable suggestions! I really appreciate you pointing out the issues, and I will immediately update and refine the translation file based on your feedback to ensure it is more accurate and clear.
If you have any further suggestions or comments, feel free to let me know.
Thanks again for your help!

13579606
13579606 approved these changes Dec 4, 2024
View reviewed changes
Copy link

@13579606 13579606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miaowumiaomiaowu Great work! Thanks for the contribution. It looks much better.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@hanouticelina hanouticelina self-requested a review December 4, 2024 08:52
hanouticelina
hanouticelina approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @miaowumiaomiaowu, thanks a lot for this contribution 🤗 looks good to me, we are good to merge!

@hanouticelina
Copy link
Contributor

And of course thanks @13579606 for the review!

@hanouticelina hanouticelina merged commit 897c770 into huggingface:main Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13579606 13579606 13579606 approved these changes

@hanouticelina hanouticelina hanouticelina approved these changes

@stevhliu stevhliu Awaiting requested review from stevhliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miaowumiaomiaowu @HuggingFaceDocBuilderDev @hanouticelina @stevhliu @13579606