Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logo in README when dark mode is on #2669

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fix logo in README when dark mode is on #2669

merged 2 commits into from
Nov 21, 2024

Conversation

hanouticelina
Copy link
Contributor

@hanouticelina hanouticelina commented Nov 21, 2024

Tiny PR to fix the logo when dark mode is on. A dark mode compatible logo has been added in https://huggingface.co/datasets/huggingface/documentation-images/blob/main/huggingface_hub-dark.svg

before:
Screenshot 2024-11-21 at 14 15 50

now:
Screenshot 2024-11-21 at 14 36 53

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting :)
Worth updating it in translated READMEs (https://github.com/huggingface/huggingface_hub/tree/main/i18n)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@hanouticelina
Copy link
Contributor Author

Thanks for spotting :) Worth updating it in translated READMEs (https://github.com/huggingface/huggingface_hub/tree/main/i18n)

done in 25d506a!

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hanouticelina hanouticelina merged commit fcecbb8 into main Nov 21, 2024
17 checks passed
@hanouticelina hanouticelina deleted the fix-readme branch November 21, 2024 14:05
@julien-c
Copy link
Member

nice! cc @gary149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants