Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write the ref file unless necessary #2657

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Don't write the ref file unless necessary #2657

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ce2452
Don't write the ref file unless necessary
d8ahazard Nov 7, 2024
27bf15a
Add exception handling when dealing with ref file
d8ahazard Nov 8, 2024
9b1213e
Update src/huggingface_hub/_snapshot_download.py
d8ahazard Nov 13, 2024
d7be748
Merge branch 'main' into main
Wauplin Nov 13, 2024
f7da2e9
Update src/huggingface_hub/_snapshot_download.py
Wauplin Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/huggingface_hub/_snapshot_download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,12 @@ def snapshot_download(
# In that case store a ref.
if revision != commit_hash:
ref_path = os.path.join(storage_folder, "refs", revision)
os.makedirs(os.path.dirname(ref_path), exist_ok=True)
with open(ref_path, "w") as f:
f.write(commit_hash)
try:
os.makedirs(os.path.dirname(ref_path), exist_ok=True)
with open(ref_path, "w") as f:
f.write(commit_hash)
except OSError as e:
logger.warning(f"Ignored error while writing commit hash to {ref_path}: {e}.")

# we pass the commit_hash to hf_hub_download
# so no network call happens if we already
Expand Down
Loading