Fix download local dir edge case (remove lru_cache) #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
thanks @Wauplin! I usually lean towards keeping @lru_cache and simplifying the functions as much as possible but in this case, it's worth prioritizing simplicity over minor performance optimizations, especially when the cost of a few extra disk operations is probably negligible
|
Thanks for the reviews 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2607.
See #2607 (comment) for explanations.
In the end I went for the solution to remove
@lru_cacheusage. This leads to more IO disk calls but less code complexity. Hopefully the extra cost is likely to be negligible.