Fix PermissionError while creating '.no_exist/' directory in cache #2594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix huggingface/transformers#33897 (cc @sanketsudake).
When trying to download a file that doesn't exist on a remote repo,
huggingface_hub
caches the information locally. Next time the user tries to download this file again, we will raise an error directly instead of attempting to make an HTTP call. This saves a few HTTP calls intransformers
since the lib is not always aware of which tokenizers files exists on a given repo. This feature exists only when revision is passed with a specific commit_hash.Since this feature is an optimization, it should be purely optional. That's why we have a try/catch around the
file.touch()
call to store non-existence of a given file. In huggingface/transformers#33897, @sanketsudake reported that themkdir
call is failing for them with aPermissionError
. This PR fixes this by moving it inside the try/catch (PermissionError
is a subclass ofOSError
).