Fix snapshot download when local_dir is provided.
#2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
reviewed
Oct 8, 2024
|
thanks for the review! I added your suggestions here : f3a8bbb |
…x-local-dir-snapshot-download
|
let's merge this :) |
hanouticelina
added a commit
that referenced
this pull request
Oct 9, 2024
* Fix snapshot download when local_dir is provided * Fix tests docstring * Add comment * Fixes post-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug reported internally in this private slack message.
Issue
The issue comes from
huggingface_hub.snapshot_download()which does not return the folder that already contains the downloaded files if:local_diris provided.local_files_only=TrueorHF_HUB_OFFLINE=True).Fix
When
local_diris provided, we should check if it exists and contains files, as it's expected to have the latest version of the repo replicated there rather than in a snapshot folder.