Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move translations to i18n #2566

Merged
merged 3 commits into from
Sep 26, 2024
Merged

docs: move translations to i18n #2566

merged 3 commits into from
Sep 26, 2024

Conversation

SauravMaheshkar
Copy link
Contributor

Mirrors the work done in huggingface/transformers#31584, issue was first raised initially at huggingface/transformers#31542

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me if transformers repo followed this "convention" (cc @stevhliu to confirm).

@SauravMaheshkar thanks for the PR. Could you update the README urls in each readme please? For now translated readmes are in /i18n but only urls in the main README.md has been updated.

@SauravMaheshkar
Copy link
Contributor Author

Fine for me if transformers repo followed this "convention" (cc @stevhliu to confirm).

@SauravMaheshkar thanks for the PR. Could you update the README urls in each readme please? For now translated readmes are in /i18n but only urls in the main README.md has been updated.

Fixed the relative links in 6e04f04

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Wauplin Wauplin merged commit 12eb785 into huggingface:main Sep 26, 2024
16 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SauravMaheshkar SauravMaheshkar deleted the saurav/i18n branch September 26, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants